Hi Tom, sounds useful to me, thanks for the KIP! The only thought that I had while reading was that this will probably raise questions about more involved conditions fairly quickly. For example the "has-header" will cause an appetite for conditions like "this-header-has-that-value". This would necessitate two parameters to be passed into the condition, which I think is not currently included in the KIP. I am not saying add this now, but might it make sense to discuss a concept of how that might look now, to avoid potential changes later on.
Just of the top of my head it might look like: transforms.conditionalExtract.condition.hasMyHeader: type:has-header transforms.conditionalExtract.condition.hasMyHeader: header-name:my-header transforms.conditionalExtract.condition.hasMyHeader: field-value:my-value Also, while writing that, I noticed that you have a version with and without "name" for your transformation in the KIP: transforms.conditionalExtract.condition.hasMyHeader: has-header:my-header and transforms.conditionalExtract.condition: has-header:my-header Is this intentional and the name is optional? Best regards, Sönke On Wed, 1 Apr 2020 at 11:12, Tom Bentley <tbent...@redhat.com> wrote: > > Does anyone have any comments, feedback or thoughts about this? > > Thanks, > > Tom > > On Tue, Mar 24, 2020 at 11:56 AM Tom Bentley <tbent...@redhat.com> wrote: > > > Hi, > > > > I've opened KIP-585 which is intended to provide a mechanism to > > conditionally apply SMTs in Kafka Connect. I'd be grateful for any > > feedback: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-585%3A+Conditional+SMT > > > > Many thanks, > > > > Tom > >
