Hi all, Thanks for the well motivated KIP, Sophie. I had some alternatives in mind, which I won't even bother to relate because I feel like the motivation made a compelling argument for the API as proposed.
One very minor point you might as well fix is that the API change is targeted at KafkaConsumer (the implementation), but should be targeted at Consumer (the interface). I agree with your discomfort about the name. Adding a "rejoin" method seems strange since there's no "join" method. Instead the way you join the group the first time is just by calling "subscribe". But "resubscribe" seems too indirect from what we're really trying to do, which is to trigger a rebalance by sending a new JoinGroup request. Another angle is that we don't want the method to sound like something you should be calling in normal circumstances, or people will be "tricked" into calling it unnecessarily. So, I think "rejoinGroup" is fine, although a person _might_ be forgiven for thinking they need to call it periodically or something. Did you consider "triggerRebalance", which sounds pretty advanced-ish, and accurately describes what happens when you call it? All in all, the KIP sounds good to me, and I'm in favor. Thanks, -John On Fri, Feb 7, 2020, at 21:22, Anna McDonald wrote: > This situation was discussed at length after a recent talk I gave. This KIP > would be a great step towards increased availability and in facilitating > lightweight rebalances. > > anna > > > > On Fri, Feb 7, 2020, 9:38 PM Sophie Blee-Goldman <sop...@confluent.io> > wrote: > > > Hi all, > > > > In light of some recent and upcoming rebalancing and availability > > improvements, it seems we have a need for explicitly triggering a consumer > > group rebalance. Therefore I'd like to propose adding a new > > rejoinGroup()method > > to the Consumer client (better method name suggestions are very welcome). > > > > Please take a look at the KIP and let me know what you think! > > > > KIP document: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-568%3A+Explicit+rebalance+triggering+on+the+Consumer > > > > JIRA: https://issues.apache.org/jira/browse/KAFKA-9525 > > > > Cheers, > > Sophie > > >
