+1 (binding), though there is definitely still some compatibility risk -- regardless of updates, people are going to have apps that may need other updates but upgrading between scala versions is still too painful for too long to warrant the effort to update. But in that case they probably aren't updating Kafka libs either.
One thing to consider would be also including a change so we stop relying on publicly exposing the scala versions. Easy initial step would be to add a shim module that just targets our default scala version as a dependency so users (especially those that don't care about scala otherwise) don't even need to think or know about scala versions. Larger step would be to eventually remove different scala versions as an option, but that probably requires documenting how to shade if you're using the core module for things like integration tests (possibly even providing a pre-shaded version for convenience). The latter is more than we probably want to do here and probably has to actually wait for major version, but former might be doable. -Ewen On Mon, Nov 18, 2019 at 9:06 AM Mickael Maison <mickael.mai...@gmail.com> wrote: > +1 (binding) > Thanks for the KIP > > On Mon, Nov 18, 2019 at 3:54 PM Sean Glover <sean.glo...@lightbend.com> > wrote: > > > > +1 (non-binding) > > > > Good idea. It will streamline the Streams Scala DSL nicely. It will > also > > affect 2.11 users of embedded-kafka. Are there any other non-broker > > dependencies that could be affected? > > > > Sean > > > > On Mon, Nov 18, 2019 at 10:43 AM Ismael Juma <ism...@juma.me.uk> wrote: > > > > > Yes, everyone is encouraged to vote. Committer votes are binding, but > we > > > are interested in what the wider community thinks too. > > > > > > Ismael > > > > > > On Mon, Nov 18, 2019 at 5:40 AM Ivan Yurchenko < > ivan0yurche...@gmail.com> > > > wrote: > > > > > > > Do I understand correctly, that non-commiters can also vote, despite > > > their > > > > votes don't decide? > > > > > > > > If so, then +1 from me. > > > > > > > > Ivan > > > > > > > > > > > > On Mon, 18 Nov 2019 at 15:19, Ismael Juma <ism...@juma.me.uk> wrote: > > > > > > > > > Hi all, > > > > > > > > > > People seemed supportive in general, so I'd like to start a vote on > > > > > KIP-531: > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-531%3A+Drop+support+for+Scala+2.11+in+Kafka+2.5 > > > > > > > > > > Ismael > > > > > > > > > > > > > > > > > > -- > > Sean Glover > > Principal Engineer, Alpakka, Lightbend, Inc. <https://lightbend.com> > > @seg1o <https://twitter.com/seg1o>, in/seanaglover > > <https://www.linkedin.com/in/seanaglover/> >
