----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20252/#review40661 -----------------------------------------------------------
Ship it! +1 for the patch to 0.8.1. Unit tests occasionally hang due to a few tests that have delete topic enabled. Other than that, unit tests are passing. - Jun Rao On April 11, 2014, 7:42 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20252/ > ----------------------------------------------------------- > > (Updated April 11, 2014, 7:42 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1356 > https://issues.apache.org/jira/browse/KAFKA-1356 > > > Repository: kafka > > > Description > ------- > > Topic metadata requests takes too long to process > > > Diffs > ----- > > core/src/main/scala/kafka/api/TopicMetadata.scala > 0513a59ed94e556894b3515dc38666ee9a66ae3d > core/src/main/scala/kafka/controller/KafkaController.scala > d6c03218ec0afdb65a7b5aa9b85eb1c029357d7a > core/src/main/scala/kafka/server/KafkaApis.scala > 0f137c5136e2320ca27c285d6ab013f6559314c4 > core/src/test/scala/unit/kafka/admin/AdminTest.scala > d5644ea40ec7678b975c4775546b79fcfa9f64b7 > core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala > 1317b4c3c60b8d1835dd6a06bf9b250398f0d47d > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 500eeca2f95d901536b1363b8c4b485c4893179f > > Diff: https://reviews.apache.org/r/20252/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >