Hi, Richard, Thanks for the updated KIP. +1 from me.
Jun On Tue, Oct 15, 2019 at 12:46 PM Richard Yu <yohan.richard...@gmail.com> wrote: > Hi Jun, > > I've updated the link accordingly. :) > Here is the updated KIP link: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-534%3A+Retain+tombstones+and+transaction+markers+for+approximately+delete.retention.ms+milliseconds > > Cheers, > Richard > > On Mon, Oct 14, 2019 at 5:12 PM Jun Rao <j...@confluent.io> wrote: > > > Hi, Richard, > > > > Thanks for the KIP. Looks good to me overall. A few minor comments below. > > > > 1. Could you change the title from "Retain tombstones" to "Retain > > tombstones and transaction markers" to make it more general? > > > > 2. Could you document which bit in the batch attribute will be used for > the > > new flag? The current format of the batch attribute is the following. > > > > * > > > ------------------------------------------------------------------------------------------------- > > * | Unused (6-15) | Control (5) | Transactional (4) | Timestamp Type > > (3) | Compression Type (0-2) | > > > > * > > > ------------------------------------------------------------------------------------------------- > > > > 3. Could you provide the reasons for the rejected proposals? For > > proposal 1, one reason is that it doesn't cover the transaction > > markers. For proposal 2, one reason is that the interval record header > > could be exposed to the clients. > > > > > > Jun > > > > > > On Mon, Oct 14, 2019 at 4:42 PM Richard Yu <yohan.richard...@gmail.com> > > wrote: > > > > > Hi all, > > > > > > The discussion for KIP-534 seems to have concluded. > > > So I wish to vote this in so that we can get it done. Its a small bug > > fix. > > > :) > > > > > > Below is the KIP link: > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-534%3A+Retain+tombstones+for+approximately+delete.retention.ms+milliseconds > > > > > > Cheers, > > > Richard > > > > > >
