Sure -- don't think we need to cover it in the KIP though. Btw: an implicit deprecation is implied by this KIP for the currently public default implementation of the `PartitionGrouper` interface. When we finally remove the public interface, we can move the default implementation into an internal package (cf https://issues.apache.org/jira/browse/KAFKA-7785)
-Matthias On 9/20/19 9:49 AM, John Roesler wrote: > +1 (non-binding). Thanks for bringing this up. > > Should we also log a deprecation warning on startup if the config is > used? It would be just one extra opportunity to learn of the > deprecation in case you missed the compiler's warning. > > -John > > On Thu, Sep 19, 2019 at 4:49 PM Bill Bejeck <bbej...@gmail.com> wrote: >> >> Thanks for the KIP Matthias. I agree with Guozhang on this one. >> >> +1 (binding) >> >> -Bill >> >> On Thu, Sep 19, 2019 at 4:41 PM Guozhang Wang <wangg...@gmail.com> wrote: >> >>> +1, we should do that long ago :) >>> >>> Guozhang >>> >>> On Thu, Sep 19, 2019 at 4:28 PM Matthias J. Sax <matth...@confluent.io> >>> wrote: >>> >>>> Hi, >>>> >>>> I would like to propose a small KIP to deprecate some public APIs that >>>> are considered "dangerous" to use, with the goal to remove them in the >>>> next major release. >>>> >>>> Because the KIP is straight forward and to make it into 2.4 release, I >>>> call directly for a vote. >>>> >>>> >>>> >>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-528%3A+Deprecate+PartitionGrouper+configuration+and+interface >>>> >>>> >>>> -Matthias >>>> >>>> >>> >>> -- >>> -- Guozhang >>>
signature.asc
Description: OpenPGP digital signature
