+1 (binding). This is a great KIP, thanks Jason! Regarding the naming of the zkVersion, I'm actually fine to name it more generally and leave a note that at the moment its value is defined as the zk version.
Guozhang On Mon, Aug 12, 2019 at 2:22 PM Jason Gustafson <ja...@confluent.io> wrote: > Hi Viktor, > > I originally named the field `CurrentVersion`. I didn't have 'Zk' in the > name in anticipation of KIP-500. I thought about it and decided it makes > sense to keep naming consistent with other APIs. Even if KIP-500 passes, > there will be some time during which it only refers to the zk version. > Eventually we'll have to decide whether it makes sense to change the name > or just introduce a new field. > > Thanks, > Jason > > On Fri, Aug 9, 2019 at 9:19 AM Viktor Somogyi-Vass < > viktorsomo...@gmail.com> > wrote: > > > Hey Jason, > > > > +1 from me too. > > One note though: since it's a new protocol we could perhaps rename > > CurrentZkVersion to something like "IsrEpoch" or "IsrVersion". I think > > that'd reflect its purpose better. > > > > Best, > > Viktor > > > > On Wed, Aug 7, 2019 at 8:37 PM Jason Gustafson <ja...@confluent.io> > wrote: > > > > > Hi All, > > > > > > I'd like to start a vote on KIP-497: > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-497%3A+Add+inter-broker+API+to+alter+ISR > > > . > > > +1 > > > from me. > > > > > > -Jason > > > > > > -- -- Guozhang
