----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20143/#review39900 -----------------------------------------------------------
core/src/main/scala/kafka/controller/TopicDeletionManager.scala <https://reviews.apache.org/r/20143/#comment72646> Can we remove the debug statements? Seem only relevant to some one-off troubleshooting exercise. core/src/main/scala/kafka/controller/TopicDeletionManager.scala <https://reviews.apache.org/r/20143/#comment72647> Reading topicsToBeDeleted outside the controllerLock can cause a race condition. Since the thread is only notified once to start the topic deletion, it might miss acting on the notification. The effect would be that the user would notice that the delete topic command had no effect and would have to retry. This violates the guarantee that the current delete topic functionality gives which is - if delete topic is issued, it will always complete. core/src/main/scala/kafka/controller/TopicDeletionManager.scala <https://reviews.apache.org/r/20143/#comment72648> Same for these debug statements. - Neha Narkhede On April 9, 2014, 12:52 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20143/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 12:52 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1363 > https://issues.apache.org/jira/browse/KAFKA-1363 > > > Repository: kafka > > > Description > ------- > > KAFKA-1363 Avoid delete topic deadlock by checking thread run status > > > Diffs > ----- > > core/src/main/scala/kafka/controller/TopicDeletionManager.scala > d29e556232ae549545bde1b6c5c9fabd5fa67bf5 > > Diff: https://reviews.apache.org/r/20143/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
