----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20109/#review39795 -----------------------------------------------------------
Ship it! Ship It! - Neha Narkhede On April 7, 2014, 11:12 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20109/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 11:12 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1366 > https://issues.apache.org/jira/browse/KAFKA-1366 > > > Repository: kafka > > > Description > ------- > > Use config names from ProducerConfig > > > KAFKA-1366.v1 > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java > 9ba7ee734d9a26ab71b192ea23d0e09b67a0da15 > core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala > 0067a5375ed33d7831548450d80bee13d0196555 > core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala > 67497dd042dfd4ad54875fe29200d67f59137264 > > Diff: https://reviews.apache.org/r/20109/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
