[
https://issues.apache.org/jira/browse/KAFKA-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Berdeen updated KAFKA-1365:
--------------------------------
Description:
After running kafka-preferred-replica-election.sh once, a second run will fail
with "Preferred replica leader election currently in progress for ...".
The /admin/preferred_replica_election key is never deleted from ZooKeeper,
because the "isTriggeredByAutoRebalance" parameter to
onPreferredReplicaElection
(https://github.com/apache/kafka/blob/0ffec142a991849833d9767be07e895428ccaea1/core/src/main/scala/kafka/controller/KafkaController.scala#L614)
is used incorrectly. In the automatic case
(https://github.com/apache/kafka/blob/0ffec142a991849833d9767be07e895428ccaea1/core/src/main/scala/kafka/controller/KafkaController.scala#L1119),
it is set to false. In the manual case
(https://github.com/apache/kafka/blob/0ffec142a991849833d9767be07e895428ccaea1/core/src/main/scala/kafka/controller/KafkaController.scala#L1266)
the parameter is not passed, so it defaults to true.
was:
After running kafka-preferred-replica-election.sh once, a second run will fail
with "Preferred replica leader election currently in progress for ...".
The /admin/preferred_replica_election key is never deleted from ZooKeeper,
because the "isTriggeredByAutoRebalance" parameter to
onPreferredReplicaElection
([KafkaController.scala:614|https://github.com/apache/kafka/blob/0ffec142a991849833d9767be07e895428ccaea1/core/src/main/scala/kafka/controller/KafkaController.scala#L614])
is used incorrectly. In the automatic case
([KafkaController.scala:1119|https://github.com/apache/kafka/blob/0ffec142a991849833d9767be07e895428ccaea1/core/src/main/scala/kafka/controller/KafkaController.scala#L1119]),
it is set to false. In the manual case
([KafkaController.scala:1266|https://github.com/apache/kafka/blob/0ffec142a991849833d9767be07e895428ccaea1/core/src/main/scala/kafka/controller/KafkaController.scala#L1266])
the parameter is not passed, so it defaults to true.
> Second Manual preferred replica leader election command always fails
> --------------------------------------------------------------------
>
> Key: KAFKA-1365
> URL: https://issues.apache.org/jira/browse/KAFKA-1365
> Project: Kafka
> Issue Type: Bug
> Components: controller, tools
> Affects Versions: 0.8.1
> Reporter: Ryan Berdeen
> Assignee: Neha Narkhede
>
> After running kafka-preferred-replica-election.sh once, a second run will
> fail with "Preferred replica leader election currently in progress for ...".
> The /admin/preferred_replica_election key is never deleted from ZooKeeper,
> because the "isTriggeredByAutoRebalance" parameter to
> onPreferredReplicaElection
> (https://github.com/apache/kafka/blob/0ffec142a991849833d9767be07e895428ccaea1/core/src/main/scala/kafka/controller/KafkaController.scala#L614)
> is used incorrectly. In the automatic case
> (https://github.com/apache/kafka/blob/0ffec142a991849833d9767be07e895428ccaea1/core/src/main/scala/kafka/controller/KafkaController.scala#L1119),
> it is set to false. In the manual case
> (https://github.com/apache/kafka/blob/0ffec142a991849833d9767be07e895428ccaea1/core/src/main/scala/kafka/controller/KafkaController.scala#L1266)
> the parameter is not passed, so it defaults to true.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
