[
https://issues.apache.org/jira/browse/KAFKA-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938061#comment-13938061
]
Neha Narkhede commented on KAFKA-1307:
--------------------------------------
[~junrao] You mentioned that you also have a couple of logging changes that you
found useful while troubleshooting this bug. Does this patch include all of
those changes as well?
> potential socket leak in new producer and clean up
> --------------------------------------------------
>
> Key: KAFKA-1307
> URL: https://issues.apache.org/jira/browse/KAFKA-1307
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8.2
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: KAFKA-1307.patch
>
>
> Address the delta review comments from kafka-1227.
> 20. Selector and Sender: need to close socket channel on IOException in
> addition to UnresolvedHostnameException.
> 21. AbstractConfig:
> 21.1 To be consistent, we probably should change the return value of the
> following api from Long to long.
> public Long getLong(String key)
> 21.1 Could we also add getDouble(String key)?
> 22. Metadata.fetch(): The wait time is incorrect when there is an
> InterruptedException.
> 23. Add comments on BufferPool.allocate() and Struct.instanceOf() for
> clarification.
> 24. Various other minor fixes for mis-spelling.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
