----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18344/#review35175 -----------------------------------------------------------
Ship it! Just one minor comment. core/src/main/scala/kafka/admin/TopicCommand.scala <https://reviews.apache.org/r/18344/#comment65601> In the output, the config option is not immediately above the delete-config option. Perhaps it's better to say "see the configurations listed in --config". - Jun Rao On Feb. 21, 2014, 5:36 a.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18344/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 5:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1276 > https://issues.apache.org/jira/browse/KAFKA-1276 > > > Repository: kafka > > > Description > ------- > > KAFKA-1276 Make topic command list the possible topic-level configs that are > available. > > > Diffs > ----- > > core/src/main/scala/kafka/admin/TopicCommand.scala > fc8d6861ccab54f9443c871b0208b81d172f357b > > Diff: https://reviews.apache.org/r/18344/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
