> On Feb. 10, 2014, 10:19 p.m., Jun Rao wrote: > > gradle.properties, lines 21-24 > > <https://reviews.apache.org/r/17879/diff/1/?file=481157#file481157line21> > > > > Do you really intend to remove those lines? > > Joe Stein wrote: > Yes, that was intentional. > > Those values are better (more safely) kept globally in > ~/.gradle/gradle.properties along with signing.keyId, signing.password, > signing.secretKeyRingFile > > My intent was to document setting these in the release documentation > wiki. They should not be checked into the repo but kept global IMHO.
Ok, then could you update README and build.gradle (the part that references local maven testing) accordingly? - Jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17879/#review34115 ----------------------------------------------------------- On Feb. 9, 2014, 3:30 p.m., Joe Stein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17879/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2014, 3:30 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1245 > https://issues.apache.org/jira/browse/KAFKA-1245 > > > Repository: kafka > > > Description > ------- > > KAFKA-1245 the jar files and pom are not being signed so nexus is failing to > publish them > > > Diffs > ----- > > build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2 > gradle.properties ad7a2f0f62930515ed0b74250dcc63069fb988de > > Diff: https://reviews.apache.org/r/17879/diff/ > > > Testing > ------- > > > Thanks, > > Joe Stein > >
