----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17880/#review34133 -----------------------------------------------------------
Ship it! Minor comments only. build.gradle <https://reviews.apache.org/r/17880/#comment64122> If clients is included in compile do we still need to specify it in testCompile? core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala <https://reviews.apache.org/r/17880/#comment64126> Can you? This is a consumer config file right? core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala <https://reviews.apache.org/r/17880/#comment64127> Better change to "Embedded producer config file" core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala <https://reviews.apache.org/r/17880/#comment64132> producerIndex would better be AtomicInteger? - Guozhang Wang On Feb. 9, 2014, 8:02 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17880/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2014, 8:02 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1237 > https://issues.apache.org/jira/browse/KAFKA-1237 > > > Repository: kafka > > > Description > ------- > > Removed whitespace > > > Mirror maker with 08 consumer and 09 producer > > > Mirror maker with 08 consumer and 09 producer > > > Diffs > ----- > > build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2 > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala PRE-CREATION > > Diff: https://reviews.apache.org/r/17880/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
