----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/ -----------------------------------------------------------
(Updated Feb. 8, 2014, 7:07 p.m.) Review request for kafka. Bugs: KAFKA-330 https://issues.apache.org/jira/browse/KAFKA-330 Repository: kafka Description (updated) ------- KAFKA-330: Joel's follow up review comments Diffs (updated) ----- core/src/main/scala/kafka/controller/ControllerChannelManager.scala a1ee5a707412166629cf9025cac054570d6d27c0 core/src/main/scala/kafka/controller/KafkaController.scala d812cb4121d7f8705c6d54eae2fb67d824a5f79f core/src/main/scala/kafka/controller/PartitionStateMachine.scala 57c96b5539f20d53238280b6e059325c757bddcf core/src/main/scala/kafka/controller/ReplicaStateMachine.scala 613aec6f40db5831f62e1391450ef02b63ae3390 core/src/main/scala/kafka/controller/TopicDeletionManager.scala 91a446ddc8aeb2ac90a62e274f612da45a67f772 core/src/main/scala/kafka/server/KafkaApis.scala c56ad503d83e31850cc2032d192d29506de96fdd core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala 974b057a880569ddd2035980d317147d892cf24f Diff: https://reviews.apache.org/r/17460/diff/ Testing ------- Several integration tests added to test - 1. Topic deletion when all replica brokers are alive 2. Halt and resume topic deletion after a follower replica is restarted 3. Halt and resume topic deletion after a controller failover 4. Request handling during topic deletion 5. Topic deletion and partition reassignment in parallel 6. Topic deletion and preferred replica election in parallel 7. Topic deletion and per topic config changes in parallel Thanks, Neha Narkhede