> On Feb. 6, 2014, 10:36 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java, line 41 > > <https://reviews.apache.org/r/17649/diff/7/?file=469305#file469305line41> > > > > That's right. > > > > The existing mirror maker uses Utils.abs(java.util.Arrays.hashCode...) > > We should just stick with that.
Yup. Jay already pointed it out in his review earlier. > On Feb. 6, 2014, 10:36 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java, line 89 > > <https://reviews.apache.org/r/17649/diff/7/?file=469305#file469305line89> > > > > It's a bit odd to have this written in java and be under > > core/src/main/scala. > > > > Also, if this is not a temporary implementation then can you use an > > option > > parser as opposed to directly grabbing the CLI args? > > > > Also, I don't see any of the logging from before which we would want > > even if it is a temporary tool under test. > > I think most of these will have to be addressed in a new patch and rb as it seems like it is better to keep it in Scala. > On Feb. 6, 2014, 10:36 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java, line 71 > > <https://reviews.apache.org/r/17649/diff/7/?file=469305#file469305line71> > > > > If the producer is configured to throw QFE or if it throws any other > > exception, then this would effectively stop this mirror thread. Producer cannot throw QFE in blocking mode which is hard coded in the mirror maker and if it throws some other unexpected error, that is a bug in the mirror maker and it should exist rather than continue. - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17649/#review33851 ----------------------------------------------------------- On Feb. 4, 2014, 9:12 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17649/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 9:12 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1137 and KAFKA-1237 > https://issues.apache.org/jira/browse/KAFKA-1137 > https://issues.apache.org/jira/browse/KAFKA-1237 > > > Repository: kafka > > > Description > ------- > > Removed the tabs > > > Rebased to new producer API changes > > > removing whitespaces > > > removing whitespaces > > > Joel's review suggestions > > > Mirror maker using new producer. Does not work for auto created topics > (KAFKA-1238) > > > Diffs > ----- > > bin/kafka-run-class.sh 416ecadf27333d1524518e8229541d161449e282 > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java PRE-CREATION > project/Build.scala ddcfc4176e68933377590e095c07283083249f4a > > Diff: https://reviews.apache.org/r/17649/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
