> On Feb. 3, 2014, 7:55 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java, line 118 > > <https://reviews.apache.org/r/17649/diff/1/?file=462835#file462835line118> > > > > Can we try just one producer thread? Also, if you do go with multiple > > producers then I think you will need to extract the key and if a key is > > present then send it to the a designated producer thread to ensure ordering > > within keys. (This is currently done in the existing mirror maker).
Included multiple producer mainly to allow scaling producer throughput within one mirror maker instance, since I'm not currently sure if the producer throughput is high enough. We can always start by using just one producer. You have a good point about distributing the keyed data, will include that in the updated diff > On Feb. 3, 2014, 7:55 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java, line 125 > > <https://reviews.apache.org/r/17649/diff/1/?file=462835#file462835line125> > > > > Producers are not shut down cleanly. This was in my local diff, forgot to upload it. Will include it in the next diff. - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17649/#review33480 ----------------------------------------------------------- On Feb. 3, 2014, 1:02 a.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17649/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 1:02 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1237 > https://issues.apache.org/jira/browse/KAFKA-1237 > > > Repository: kafka > > > Description > ------- > > Mirror maker using new producer. Does not work for auto created topics > (KAFKA-1238) > > > Diffs > ----- > > bin/kafka-run-class.sh 416ecadf27333d1524518e8229541d161449e282 > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java PRE-CREATION > project/Build.scala ddcfc4176e68933377590e095c07283083249f4a > > Diff: https://reviews.apache.org/r/17649/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
