[ 
https://issues.apache.org/jira/browse/KAFKA-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883481#comment-13883481
 ] 

Jay Kreps commented on KAFKA-1227:
----------------------------------

Hey Edward,

What I actually want for the Cluster constructor is to make it private to my 
jar but since that isn't possible I went with public so it is accessible to 
unit tests. In general that API wouldn't be used as the client tells you about 
the cluster not vice versa. But there is no harm in using the more general 
types, so I'll change those to Collection.

The partitionsFor call does need to return a list as one use case for that is 
being able to fetch by index, which is not part of Collection. This is useful 
when implementing a partitioner.

> Code dump of new producer
> -------------------------
>
>                 Key: KAFKA-1227
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1227
>             Project: Kafka
>          Issue Type: New Feature
>            Reporter: Jay Kreps
>            Assignee: Jay Kreps
>         Attachments: KAFKA-1227.patch
>
>
> The plan is to take a dump of the producer code "as is" and then do a series 
> of post-commit reviews to get it into shape. This bug tracks just the code 
> dump.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to