Re: Review Request 17248: Patch for KAFKA-1226

[Joris Van Remoortere]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17248/
-----------------------------------------------------------

(Updated Jan. 23, 2014, 6:17 p.m.)


Review request for kafka.


Bugs: KAFKA-1226
    https://issues.apache.org/jira/browse/KAFKA-1226


Repository: kafka


Description
-------

KAFKA-1226


Diffs (updated)
-----

  core/src/main/scala/kafka/admin/AddPartitionsCommand.scala 7f03708 
  core/src/main/scala/kafka/admin/AdminUtils.scala d6ab275 
  core/src/main/scala/kafka/admin/CreateTopicCommand.scala 84c2095 
  core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 2f706c9 
  core/src/main/scala/kafka/client/ClientUtils.scala 1d2f81b 
  core/src/main/scala/kafka/cluster/Broker.scala 9407ed2 
  core/src/main/scala/kafka/server/KafkaConfig.scala 41c9626 
  core/src/main/scala/kafka/server/KafkaZooKeeper.scala 553640f 
  core/src/main/scala/kafka/utils/ZkUtils.scala c21bc60 
  core/src/test/scala/other/kafka/TestLogPerformance.scala 9f3bb40 
  core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 2436289 
  core/src/test/scala/unit/kafka/admin/AdminTest.scala a480881 
  core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala 
f43ac8f 
  core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala 1ee34b9 
  core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala 2317760 
  core/src/test/scala/unit/kafka/integration/FetcherTest.scala c5cddea 
  core/src/test/scala/unit/kafka/integration/LazyInitProducerTest.scala c3c7631 
  core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala f764151 
  core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala 26e9bd6 
  core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala edf8555 
  core/src/test/scala/unit/kafka/log/LogManagerTest.scala ce893bf 
  core/src/test/scala/unit/kafka/log/LogOffsetTest.scala 1a9cc01 
  core/src/test/scala/unit/kafka/log/LogTest.scala df90695 
  core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 67497dd 
  core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 69c88c7 
  core/src/test/scala/unit/kafka/producer/ProducerTest.scala 2cabfbb 
  core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala 70e4b51 
  core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 947e795 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala a06cfff 

Diff: https://reviews.apache.org/r/17248/diff/


Testing
-------


File Attachments
----------------

rack_aware_replica_assignment_v1.patch
  
https://reviews.apache.org/media/uploaded/files/2014/01/23/394cef99-f800-4d94-bc59-fdb6c68b53f5__rack_aware_replica_assignment_v1.patch


Thanks,

Joris Van Remoortere