----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16357/#review30724 -----------------------------------------------------------
Ship it! - Guozhang Wang On Dec. 19, 2013, 9:57 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16357/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2013, 9:57 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1185 > https://issues.apache.org/jira/browse/KAFKA-1185 > > > Repository: kafka > > > Description > ------- > > Addressed Guozhang's review comment > > > 1) Included a new API that allows the current leader to resign 2) Changed > controller to correctly initialize its data structures on resigning as > controller > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > 965d0e56b5a5b10953904235034e974a5b658321 > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala > cc6f1eba291c113a1b84259441efc1b64463affe > > Diff: https://reviews.apache.org/r/16357/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
