[
https://issues.apache.org/jira/browse/KAFKA-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840328#comment-13840328
]
Jun Rao commented on KAFKA-1036:
--------------------------------
We are relying on file renaming being an atomic operation. So, if supported, we
should still do rename, instead of deletion followed by creation. The issue
with the latter is that if the broker crashes btw the two operations, the
broker is left with no checkpoint file.
> Unable to rename replication offset checkpoint in windows
> ---------------------------------------------------------
>
> Key: KAFKA-1036
> URL: https://issues.apache.org/jira/browse/KAFKA-1036
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8.1
> Environment: windows
> Reporter: Timothy Chen
> Priority: Critical
> Labels: windows
> Fix For: 0.8.1
>
> Attachments: filelock.patch.diff
>
>
> Although there was a fix for checkpoint file renaming in windows that tries
> to delete the existing checkpoint file if renamed failed, I'm still seeing
> renaming errors on windows even though the destination file doesn't exist.
> A bit investigation shows that it wasn't able to rename the file since the
> kafka jvm still holds a fie lock on the tmp file and wasn't able to rename
> it.
> Attaching a patch that calls a explict writer.close so it can release the
> lock and can able to rename it.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
