----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14730/#review27677 -----------------------------------------------------------
core/src/main/scala/kafka/server/AbstractFetcherManager.scala <https://reviews.apache.org/r/14730/#comment53753> I think it's simpler to use mapLock for the whole method. It also reduces the locking overhead. core/src/main/scala/kafka/server/AbstractFetcherThread.scala <https://reviews.apache.org/r/14730/#comment53757> core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/14730/#comment53744> catched ==> caught core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/14730/#comment53748> Ditto as above. - Jun Rao On Oct. 28, 2013, 10:13 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14730/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2013, 10:13 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1001 > https://issues.apache.org/jira/browse/KAFKA-1001 > > > Repository: kafka > > > Description > ------- > > KAFKA-1001.v4 > > > KAFKA-1001.v3 > > > KAFKA-1001.v3 > > > KAFKA-1001.v2.9 > > > KAFKA-1001.v2 > > > KAFKA-1001.v1.91 > > > KAFKA-1001.v1.9 > > > KAFKA-1001.v1.6 > > > KAFKA-1001.v1.5 > > > KAFKA-1001.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 5ccecd179d33abfc14dcefc35dd68de7474c6978 > core/src/main/scala/kafka/common/ErrorMapping.scala > 153bc0b078d21200c02c47dd5ad9b7a7e3326ec4 > core/src/main/scala/kafka/common/TopicAndPartition.scala > 63596b7b2260d2e954e5edece2470985d1cf7ae2 > core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala > 566ca46d113ee7da4b38ee57302ba183b59ab5d6 > core/src/main/scala/kafka/consumer/ConsumerFetcherThread.scala > dda0a8f041f242bf8a501a8cbd2b9c0258323f96 > core/src/main/scala/kafka/log/LogManager.scala > 47197153c5d3797d2e2a2f9539d9cd55501468e3 > core/src/main/scala/kafka/server/AbstractFetcherManager.scala > 15b7bd31446ffb97b8ed0fa6461649a01d81c7e9 > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > c64260f12bdd6b6c964875e1f3873156442e44e1 > core/src/main/scala/kafka/server/ReplicaManager.scala > ee1cc0cf451b691eb91d9158ca765aeb60fc3dc8 > > Diff: https://reviews.apache.org/r/14730/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
