----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14898/#review27615 -----------------------------------------------------------
core/src/main/scala/kafka/network/RequestChannel.scala <https://reviews.apache.org/r/14898/#comment53646> We should rename dequeueTimeMs to requestDequeueTimeMs. core/src/main/scala/kafka/network/RequestChannel.scala <https://reviews.apache.org/r/14898/#comment53645> We should rename queueTime to requestQueueTime. core/src/main/scala/kafka/network/RequestChannel.scala <https://reviews.apache.org/r/14898/#comment53644> We probably should rename this to RequestQueueTimeMs. - Jun Rao On Oct. 27, 2013, 1:45 a.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14898/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2013, 1:45 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1060 > https://issues.apache.org/jira/browse/KAFKA-1060 > > > Repository: kafka > > > Description > ------- > > KAFKA-1060.v2 > > > KAFKA-1060.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/network/RequestChannel.scala > 77d7ec034d8534c0d3aef49e9516b9b853c99cb2 > > Diff: https://reviews.apache.org/r/14898/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
