[
https://issues.apache.org/jira/browse/KAFKA-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-1042:
-----------------------------
Attachment: KAFKA-1042-v2.patch
Rebased that patch with minor changes.
Also I found a subtle problem with all the tests in LogTest--we aren't passing
the time instance in Log into LogSegments we create and hence they are
defaulting to SystemTime. This leads to us comparing times from SystemTime to
times from MockTime. This was working only because the tests took less than 1
ms and MockTime initializes to System.currentTimeMillis! This explains a lot of
the sporadic failures in LogTest.
> Fix segment flush logic
> -----------------------
>
> Key: KAFKA-1042
> URL: https://issues.apache.org/jira/browse/KAFKA-1042
> Project: Kafka
> Issue Type: Improvement
> Components: log
> Affects Versions: 0.8.1
> Environment: centos6.4
> Reporter: Joris Van Remoortere
> Assignee: Jay Kreps
> Priority: Critical
> Labels: patch
> Attachments: flush_segment_fix-v1.patch, KAFKA-1042-v2.patch
>
>
> The logic for deciding which segments to flush in log.flush() was missing the
> case where the (from, to) range was within a single segment. This case
> enables some of the features in the server.properties file such as message
> volume / time based triggers for fsync on the log files.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
