> On Oct. 15, 2013, 8:03 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/GetOffsetShell.scala, line 71 > > <https://reviews.apache.org/r/14638/diff/1/?file=364653#file364653line71> > > > > Nice use of clientId. We should do this in every tool. I would suggest > > we also prepend this with InetAddress.getLocalHost.getHostName
actually nm :) we anyway log the IP on the server-side request logs. - Joel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14638/#review27039 ----------------------------------------------------------- On Oct. 14, 2013, 10:50 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14638/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2013, 10:50 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1086 > https://issues.apache.org/jira/browse/KAFKA-1086 > > > Repository: kafka > > > Description > ------- > > Improved GetOffsetShell to query metadata automatically, add batch offset > request for all partitions of a topic and improve usability > > > Diffs > ----- > > core/src/main/scala/kafka/tools/GetOffsetShell.scala > 2b9438ae3a4da2c7f97e05fb26bc179fe48f137d > > Diff: https://reviews.apache.org/r/14638/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
