[ 
https://issues.apache.org/jira/browse/KAFKA-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789350#comment-13789350
 ] 

John Fung commented on KAFKA-1078:
----------------------------------

1. Before the patch (no controller entity id found)

2013-10-04 01:04:38,070 - INFO - 
======================================================
2013-10-04 01:04:38,070 - INFO - Found controller with entity id: 
2013-10-04 01:04:38,070 - INFO - 
======================================================

2013-10-04 01:04:38,070 - INFO - 
======================================================
2013-10-04 01:04:38,070 - INFO - stopping controller : { "brokerid":1, 
"timestamp":"1380873836165", "version":1 }
2013-10-04 01:04:38,070 - INFO - 
======================================================

2013-10-04 01:04:38,071 - INFO - 
======================================================
2013-10-04 01:04:38,071 - INFO - Exception while running test ''
2013-10-04 01:04:38,071 - INFO - 
======================================================
Traceback (most recent call last):
  File 
"/home/user/kafka/system_test/replication_testsuite/replica_basic_test.py", 
line 301, in runTest
    kafka_system_test_utils.stop_remote_entity(self.systemTestEnv, 
controllerDict["entity_id"], 
self.testcaseEnv.entityBrokerParentPidDict[controllerDict["entity_id"]])
KeyError: ''


2. After the patch (controller entity id found)

2013-10-07 16:30:48,122 - INFO - 
======================================================
2013-10-07 16:30:48,122 - INFO - Found controller with entity id: 1
2013-10-07 16:30:48,122 - INFO - 
======================================================

2013-10-07 16:30:48,123 - INFO - 
======================================================
2013-10-07 16:30:48,123 - INFO - stopping controller : 1
2013-10-07 16:30:48,123 - INFO - 
======================================================
2013-10-07 16:30:48,123 - DEBUG - executing command [ssh localhost 'pid=26805; 
prev_pid=""; echo $pid; while [[ "x$pid" != "x" ]]; do prev_pid=$pid;   for 
child in $(ps -o pid,ppid a
x | awk "{ if ( \$2 == $pid ) { print \$1 }}");     do echo $child; pid=$child; 
  done;   if [ $prev_pid == $pid ]; then     break;   fi; done' 2> /dev/null 
(system_test_utils)
2013-10-07 16:30:48,477 - DEBUG - terminating (SIGTERM) process id: 26805 in 
host: localhost (kafka_system_test_utils)


> Update System Test to handle controller data returned by ZK
> -----------------------------------------------------------
>
>                 Key: KAFKA-1078
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1078
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: John Fung
>            Assignee: John Fung
>             Fix For: 0.8
>
>         Attachments: kafka-1078.patch
>
>
> There is a change in the result returned by ZK when querying for controller:
> 2013-10-07 09:39:15,599 - DEBUG - executing command [ssh localhost 
> "JAVA_HOME=/export/apps/jdk/JDK-1_6_0_27 
> /home/user/kafka/bin/kafka-run-class.sh org.apache.zookeeper.ZooKeeperMain 
> -server localhost:2188 get /controller 2> /dev/null | tail -1"] 
> (kafka_system_test_utils)
> 1. Previously it returned : 1
> 2. It is currently returning : { "brokerid":1, "timestamp":"1381163914835", 
> "version":1 }
> The impact is that System Test doesn't have the correct entity ID for 
> bouncing controller. There are a few test cases that are impacted by this 
> change when they are bouncing the controller.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to