----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14188/#review26193 -----------------------------------------------------------
Mainly wanted to try out the patch review tool. This draft patch does not work due to the issue mentioned below. core/src/main/scala/kafka/producer/Producer.scala <https://reviews.apache.org/r/14188/#comment51185> This doesn't work with the createUtils method below as it will still try to find a constructor with an argument of type VerifiableProperties core/src/main/scala/kafka/utils/Utils.scala <https://reviews.apache.org/r/14188/#comment51186> The following getConstructor call fails in this diff - e.g., try running AsyncProducerTest. - joel koshy On Sept. 17, 2013, 11:52 p.m., joel koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14188/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2013, 11:52 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1049 > https://issues.apache.org/jira/browse/KAFKA-1049 > > > Repository: kafka > > > Description > ------- > > This doesn't work yet; trying out the patch review tool. > > > Diffs > ----- > > core/src/main/scala/kafka/producer/Producer.scala > f5829198ebe7555f1e80bcdd02b688c918050426 > core/src/main/scala/kafka/serializer/Encoder.scala > 020e73c72a310e874ba07cf0691517a61c1fc35f > core/src/main/scala/kafka/utils/Utils.scala > e0a5a27c72abf3560f68fc6c2dbfc67d90cc5cd9 > core/src/main/scala/kafka/utils/VerifiableProperties.scala > d694ba98522a0aa2fc9cac84ebcfc4bd51505300 > > Diff: https://reviews.apache.org/r/14188/diff/ > > > Testing > ------- > > > Thanks, > > joel koshy > >
