[ 
https://issues.apache.org/jira/browse/KAFKA-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743251#comment-13743251
 ] 

Neha Narkhede commented on KAFKA-1009:
--------------------------------------

Thanks for the patch, Guozhang. Two comments -

1. We should default mutable=true in FileMessageSet
2. I think we should take this patch on trunk. Could you provide another patch 
for trunk since this one fails?
                
> DumpLogSegments tool should return error on non-existing files
> --------------------------------------------------------------
>
>                 Key: KAFKA-1009
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1009
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Guozhang Wang
>            Priority: Minor
>             Fix For: 0.8.1
>
>         Attachments: KAFKA-1009.v1.patch
>
>
> If we run the tool on an non-existing file, we get the following
> bin/kafka-run-class.sh kafka.tools.DumpLogSegments --files 00.log
> Dumping 00.log
> Starting offset: 0
> The tool should return an error message instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to