[ 
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737162#comment-13737162
 ] 

Swapnil Ghike edited comment on KAFKA-990 at 8/12/13 6:23 PM:
--------------------------------------------------------------

The rebased patch also failed for me on 0.8 HEAD

$patch -p1 --dry-run < ~/Downloads/KAFKA-990-v1-rebased.patch 
patching file core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
patching file core/src/main/scala/kafka/utils/ZkUtils.scala
Hunk #1 succeeded at 620 (offset 42 lines).
patching file core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
Hunk #1 FAILED at 29.
Hunk #2 FAILED at 81.

                
      was (Author: swapnilghike):
    The rebased patch also failed for me on 0.8 HEAD

                  
> Fix ReassignPartitionCommand and improve usability
> --------------------------------------------------
>
>                 Key: KAFKA-990
>                 URL: https://issues.apache.org/jira/browse/KAFKA-990
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Sriram Subramanian
>            Assignee: Sriram Subramanian
>         Attachments: KAFKA-990-v1.patch, KAFKA-990-v1-rebased.patch
>
>
> 1. The tool does not register for IsrChangeListener on controller failover.
> 2. There is a race condition where the previous listener can fire on 
> controller failover and the replicas can be in ISR. Even after re-registering 
> the ISR listener after failover, it will never be triggered.
> 3. The input the tool is a static list which is very hard to use. To improve 
> this, as a first step the tool needs to take a list of topics and list of 
> brokers to do the assignment to and then generate the reassignment plan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to