[ 
https://issues.apache.org/jira/browse/KAFKA-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705248#comment-13705248
 ] 

Jay Kreps commented on KAFKA-965:
---------------------------------

- core/src/main/scala/kafka/admin/AdminUtils.scala: You changed the name of 
replicaIndex back to getWrappedIndex? Is this intentional?
- core/src/main/scala/kafka/server/HighwaterMarkCheckpoint.scala you are 
re-adding this file but it has been replaced by OffsetIndex
- This is not due to the merge, but the manual synchronization done for 
updatemetadata is really bad code. If we want to do ad hoc synchronization that 
should have been wrapped in a MetadataCache class. As it is verifying the 
correctness of that involves examinging all of KafkaApis.
                
> merge c39d37e9dd97bf2462ffbd1a96c0b2cb05034bae from 0.8 to trunk
> ----------------------------------------------------------------
>
>                 Key: KAFKA-965
>                 URL: https://issues.apache.org/jira/browse/KAFKA-965
>             Project: Kafka
>          Issue Type: Task
>          Components: core
>    Affects Versions: 0.8.1
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>         Attachments: kafka-965.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to