[ 
https://issues.apache.org/jira/browse/KAFKA-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neha Narkhede updated KAFKA-911:
--------------------------------

    Attachment: kafka-911-v2.patch

I agree with Joel's suggestion. Removing the shutting down brokers from the ISR 
is better. This patch sends the LeaderAndIsrRequest with the reduced isr to the 
new leader for the partitions on the shutting down brokers. This ensures the 
leader will remove the shutting down broker from the isr in zookeeper. This 
also makes it unnecessary for the shrunk isr zookeeper write to happen during 
the controlled shutdown on the controller. 
                
> Bug in controlled shutdown logic in controller leads to controller not 
> sending out some state change request 
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-911
>                 URL: https://issues.apache.org/jira/browse/KAFKA-911
>             Project: Kafka
>          Issue Type: Bug
>          Components: controller
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: Neha Narkhede
>            Priority: Blocker
>              Labels: kafka-0.8, p1
>         Attachments: kafka-911-v1.patch, kafka-911-v2.patch
>
>
> The controlled shutdown logic in the controller first tries to move the 
> leaders from the broker being shutdown. Then it tries to remove the broker 
> from the isr list. During that operation, it does not synchronize on the 
> controllerLock. This causes a race condition while dispatching data using the 
> controller's channel manager.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to