[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622628#comment-13622628 ]
Jun Rao commented on KAFKA-330: ------------------------------- Thanks for the patch. Even though the patch is not big, it touches quite a few critical components such as controller, replica manager, and log. It will take some time to stabilize this. We probably should consider pushing this out of 0.8 so that we don't delay the 0,8 release too much. One quick comment: 1. KafkaControler.onTopicsDeletion(): Why do we need to read things like partitionAssignment and brokers from ZK? Could we just use the cached data in controller context? > Add delete topic support > ------------------------- > > Key: KAFKA-330 > URL: https://issues.apache.org/jira/browse/KAFKA-330 > Project: Kafka > Issue Type: Bug > Components: controller, log, replication > Affects Versions: 0.8 > Reporter: Neha Narkhede > Assignee: Swapnil Ghike > Priority: Blocker > Labels: features, kafka-0.8, p2, project > Fix For: 0.8 > > Attachments: kafka-330-v1.patch > > > One proposal of this API is here - > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+replication+detailed+design+V2#KafkareplicationdetaileddesignV2-Deletetopic -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira