[ 
https://issues.apache.org/jira/browse/KAFKA-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607110#comment-13607110
 ] 

Jun Rao commented on KAFKA-816:
-------------------------------

Thanks for the patch. Instead of duplicating the comments for each type of 
exception, is it better to add a comment at the beginning of catch to explain 
how different exceptions are handled? The comment should probably be added to 
handleOffsetRequest() too. Also, there is a grammar mistake in "Failed produce 
requests is ".
                
> Reduce noise in Kafka server logs due to NotLeaderForPartitionException
> -----------------------------------------------------------------------
>
>                 Key: KAFKA-816
>                 URL: https://issues.apache.org/jira/browse/KAFKA-816
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: Neha Narkhede
>            Priority: Blocker
>              Labels: kafka-0.8, p2
>         Attachments: kafka-816.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> NotLeaderForPartitionException is logged at the ERROR level with a full stack 
> trace. But really this is just an informational message on the server when a 
> client with stale metadata sends requests to the wrong leader for a 
> partition. This floods the logs either if there are many clients or few 
> clients sending many topics (migration tool or mirror maker). This should 
> probably be logged at WARN and without the stack trace

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to