[ 
https://issues.apache.org/jira/browse/KAFKA-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605513#comment-13605513
 ] 

Jay Kreps edited comment on KAFKA-804 at 3/18/13 7:44 PM:
----------------------------------------------------------

- I only see stats being updated in the case where assignOffsets is true.
- Please fix the logging to be human readable.

Can you give a patch against trunk too?
                
      was (Author: jkreps):
    - I only see stats being updated in the case where assignOffsets is true.
- Please fix the logging to be human readable.

Code quality-wise I need to see how this will get applied to trunk. Can you 
give a patch against trunk too? There I am more concerned that these changes 
not 
                  
> Incorrect index in the log of a follower
> ----------------------------------------
>
>                 Key: KAFKA-804
>                 URL: https://issues.apache.org/jira/browse/KAFKA-804
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>            Priority: Blocker
>         Attachments: kafka-804.patch
>
>
> In the follower, in log.append(), we use the offset of the 1st compressed 
> message as the offset for appending index entries. This means that the index 
> is pointing to an earlier position in the file than it should.  Instead, it 
> should use the offset of the 1st uncompressed message for appending index.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to