[
https://issues.apache.org/jira/browse/KAFKA-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601421#comment-13601421
]
Jun Rao commented on KAFKA-802:
-------------------------------
Thanks for patch v2. We need a few tweaks.
20. The assignment to firstOffset and the computation of numAppendedMessages
have to be done inside the synchronization of the lock.
21. The following statements in append are no longer valid and can be removed.
// return the offset at which the messages were appended
offsets
> Flush message interval is based on compressed message count
> -----------------------------------------------------------
>
> Key: KAFKA-802
> URL: https://issues.apache.org/jira/browse/KAFKA-802
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Neha Narkhede
> Priority: Blocker
> Attachments: kafka-802.patch, kafka-802-v2.patch
>
>
> In Log.append(), we use compressed message count to determine whether to
> flush the log or not. We should use uncompressed message count instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
