[
https://issues.apache.org/jira/browse/KAFKA-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-739:
----------------------------
Attachment: KAFKA-739-v5.patch
Jun, attached v5 patch to address your comments.
40. This is actually right, both peek, hasNext, and next will all call
makeNext() if there isn't an item ready. But peek and hasNext are idempotent
and next() isn't--it advances the iterator. I wrote a unit test that
demonstrates this.
41. Added the comment and removed the stray variable.
42. Actually the handling of nulls is not done in the serializers, it is done
in Kafka. That is no matter what serializer you use, null always deserializes
to null. You could argue either way whether this is a good thing. The downside
to pushing it isn't the serializer is that all serializers have to remember to
handle null. The advantage is that the serializer could yield a different value
for null if it wanted. Couldn't think of a use for the later so I went with the
simple thing.
> Handle null values in Message payload
> -------------------------------------
>
> Key: KAFKA-739
> URL: https://issues.apache.org/jira/browse/KAFKA-739
> Project: Kafka
> Issue Type: Bug
> Reporter: Jay Kreps
> Assignee: Jay Kreps
> Fix For: 0.8.1
>
> Attachments: KAFKA-739-v1.patch, KAFKA-739-v2.patch,
> KAFKA-739-v3.patch, KAFKA-739-v4.patch, KAFKA-739-v5.patch
>
>
> Add tests for null message payloads in producer, server, and consumer.
> Ensure log cleaner treats these as deletes.
> Test that null keys are rejected on dedupe logs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
