[ 
https://issues.apache.org/jira/browse/KAFKA-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597771#comment-13597771
 ] 

Sriram Subramanian commented on KAFKA-739:
------------------------------------------

1. OffsetMap
    a. The way the probe is calculated, we could end up having the same probe 
multiple times. Starting with attempt = hashSize - 4 to attempt = hashSize the 
probe would be the same. 
    val probe = Utils.readInt(hash, math.min(attempt, hashSize-4)) + 
math.max(0, attempt - hashSize)

2. LogCleaner
    a. Cleaner doc comments need to be updated
   
Will look at the test changes and provide comments if any.

                
> Handle null values in Message payload
> -------------------------------------
>
>                 Key: KAFKA-739
>                 URL: https://issues.apache.org/jira/browse/KAFKA-739
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jay Kreps
>            Assignee: Jay Kreps
>             Fix For: 0.8.1
>
>         Attachments: KAFKA-739-v1.patch, KAFKA-739-v2.patch, 
> KAFKA-739-v3.patch
>
>
> Add tests for null message payloads in producer, server, and consumer.
> Ensure log cleaner treats these as deletes.
> Test that null keys are rejected on dedupe logs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to