[ 
https://issues.apache.org/jira/browse/KAFKA-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596722#comment-13596722
 ] 

Sriram Subramanian commented on KAFKA-795:
------------------------------------------

1. If we are going to run the tool when there are no brokers, that does not 
seem to be a realistic case. If we still insist on checking this at startup, we 
should do it for any admin tool.
2. The tool throws an error that "path already exist" today. This is the right 
thing to do for multiple reasons
   a. There was some error during the previous run that made the controller not 
delete the path
   b. The previous run is still in progess
3. The process is asyn and hence the tool will not be able to do this.

Even 1. just seems a wasted effort to me. As long as there is atleast one 
broker, there is going to be a controller.
                
> Improvements to PreferredReplicaLeaderElection tool
> ---------------------------------------------------
>
>                 Key: KAFKA-795
>                 URL: https://issues.apache.org/jira/browse/KAFKA-795
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Swapnil Ghike
>            Assignee: Swapnil Ghike
>            Priority: Blocker
>              Labels: kafka-0.8, p2
>             Fix For: 0.8
>
>
> We can make some improvements to the PreferredReplicaLeaderElection tool:
> 1. Terminate the tool if a controller is not up and running. Currently we can 
> run the tool without having any broker running, which is kind of confusing. 
> 2. Should we delete /admin zookeeper path in PreferredReplicaLeaderElection 
> (and ReassignPartition) tool at the end? Otherwise the next run of the tool 
> complains that a replica election is already in progress. 
> 3. If there is an error, we can see it in cotroller.log. Should the tool also 
> throw an error?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to