[
https://issues.apache.org/jira/browse/KAFKA-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594965#comment-13594965
]
Jun Rao commented on KAFKA-779:
-------------------------------
Thanks for patch v2. Looks good overall. A couple of comments:
1. PreferredReplicaLeaderElectionCommand: We shouldn't let the user put in the
version # in path-to-json-file. The tool knows the version and should fill it
in. Ditto for ReassignPartitionsCommand.
2. I had the following unit test failure.
[error] Test Failed:
testPartitionReassignmentWithLeaderInNewReplicas(kafka.admin.AdminTest)
junit.framework.AssertionFailedError: Partition should have been reassigned to
0, 2, 3 expected:<List(0, 2, 3)> but was:<List(0, 1, 2)>
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.failNotEquals(Assert.java:277)
at junit.framework.Assert.assertEquals(Assert.java:64)
at
kafka.admin.AdminTest.testPartitionReassignmentWithLeaderInNewReplicas(AdminTest.scala:232)
> Standardize Zk data structures for Re-assign partitions and Preferred
> replication election
> ------------------------------------------------------------------------------------------
>
> Key: KAFKA-779
> URL: https://issues.apache.org/jira/browse/KAFKA-779
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Priority: Blocker
> Labels: kafka-0.8, p2
> Fix For: 0.8
>
> Attachments: kafka-779-v1.patch, kafka-779-v2.patch
>
>
> Follow the schema at
> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+data+structures+in+Zookeeper
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
