[ 
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586282#comment-13586282
 ] 

Neha Narkhede commented on KAFKA-671:
-------------------------------------

Looks good overall. Just one comment -

In the toString(), the map operation is not correct. If we just want to print a 
list of topic partitions, shouldn't it just be 
topicPartitionMessageSizeMap.keys.mkString(",")  ?

Other than that, I'm +1 on this. If others don't have any concerns, I can check 
this in after the above change is made

                
> DelayedProduce requests should not hold full producer request data
> ------------------------------------------------------------------
>
>                 Key: KAFKA-671
>                 URL: https://issues.apache.org/jira/browse/KAFKA-671
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Joel Koshy
>            Assignee: Sriram Subramanian
>            Priority: Blocker
>              Labels: bugs, p1
>             Fix For: 0.8.1
>
>         Attachments: outOfMemFix-v1.patch, outOfMemFix-v2.patch, 
> outOfMemFix-v2-rebase.patch, outOfMemFix-v3.patch, outOfMemFix-v4.patch, 
> outOfMemFix-v4-rebase.patch
>
>
> Per summary, this leads to unnecessary memory usage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to