[
https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584827#comment-13584827
]
Jun Rao commented on KAFKA-736:
-------------------------------
Thanks for patch v4. Looks good. A few minor comments. Once they are addressed,
the patch can be checked in.
40. SocketServerTest.testPipelinedRequestOrdering(): id, send, id2, send2 are
not referenced
41. SyncProducerTest.testProducerCanTimeout(): Should we remove the println?
42. PrimitiveApiTest: testPipelinedProduceRequests seems to fail. I suspect
that it's timing related. Also, produceList is not referenced.
> Add an option to the 0.8 producer to mimic 0.7 producer behavior
> ----------------------------------------------------------------
>
> Key: KAFKA-736
> URL: https://issues.apache.org/jira/browse/KAFKA-736
> Project: Kafka
> Issue Type: Improvement
> Components: producer
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Neha Narkhede
> Priority: Blocker
> Labels: p1, replication-performance
> Attachments: check-message-ordering.py, kafka-736-draft.patch,
> kafka-736-draft-producer-latency-20threads-acks1.out, kafka-736-v1.patch,
> kafka-736-v2.patch, kafka-736-v3.patch,
> kafka-736-v3-producer-latency-20threads-acks1.out, kafka-736-v4.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I profiled a producer throughput benchmark between a producer and a remote
> broker. It turns out that the background send threads spends ~97% of its time
> waiting to read the acknowledgement from the broker.
> I propose we change the current behavior of request.required.acks=0 to mean
> no acknowledgement from the broker. This will mimic the 0.7 producer behavior
> and will enable tuning the producer for very high throughput.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
