[ 
https://issues.apache.org/jira/browse/KAFKA-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577681#comment-13577681
 ] 

Jun Rao commented on KAFKA-757:
-------------------------------

Thanks for the patch. Good catch. I think problem B can explain item 2 in 
KAFKA-750.

I am not so sure about the fix in OffsetIndex though. indexSlotFor() assumes 
that the index is valid. However, when truncate() is called, the index may not 
be valid. Instead of changing the assumption in indexSlotFor(), it's probably 
better to implement truncate() directly without relying on index lookups.
                
> System Test Hard Failure cases : "Fatal error during KafkaServerStable 
> startup" when hard-failed broker is re-started
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-757
>                 URL: https://issues.apache.org/jira/browse/KAFKA-757
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: John Fung
>            Assignee: Swapnil Ghike
>            Priority: Blocker
>              Labels: 0.8, replication-testing
>         Attachments: kafka-757-v1.patch, kafka-757-v2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to