[
https://issues.apache.org/jira/browse/KAFKA-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562890#comment-13562890
]
Jun Rao commented on KAFKA-700:
-------------------------------
Looks good. Just 1 comment:
10. RichString.format() seems expensive. We probably should use string + in the
following statement.
requestLogger.trace("Handling request: %s from remote address:
%s".format(request.requestObj, request.remoteAddress))
> log client ip when we log each request on the broker
> ----------------------------------------------------
>
> Key: KAFKA-700
> URL: https://issues.apache.org/jira/browse/KAFKA-700
> Project: Kafka
> Issue Type: Improvement
> Components: clients
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Sriram Subramanian
> Priority: Blocker
> Labels: p2
> Attachments: Kafka-700.patch, Kafka-700-v2.patch
>
>
> For debugging purpose, it's useful to know the client ip from which a request
> comes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
