[
https://issues.apache.org/jira/browse/KAFKA-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sriram Subramanian updated KAFKA-696:
-------------------------------------
Attachment: cleanup-v2.patch
1. The reason why I did not do that was because ReplicaRequest does not extend
from RequestReponse. I kept what was there as is but moved the logging of the
request outside to kafkaapi.
2. ProducerRequest logs the size for each message set.
3.1 It was an old patch and looks like there were conflicts.
3.2 Each request also prints the request name now. Hence moved these lines to
the parent method.
4. Removed the deserializations and just log the request object.
> Fix toString() API for all requests to make logging easier to read
> ------------------------------------------------------------------
>
> Key: KAFKA-696
> URL: https://issues.apache.org/jira/browse/KAFKA-696
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Sriram Subramanian
> Attachments: cleanup-v1.patch, cleanup-v2.patch
>
>
> It will be useful to have consistent logging styles for all requests. Right
> now, we depend on the default toString implementation and the problem is that
> it is very hard to read and prints out unnecessary information like the
> ByteBuffer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
