[
https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-683:
--------------------------------
Attachment: kafka-683-v2.patch
1. DefaultEventHandler: Good suggestion, included it
2. FileMessageSet: Done
3. KafkaMigrationTool: This was accidental, reverted it
4.1 Makes sense, al though we don't really need a shouldRoll variable.
Refactored this code a bit
4.2 Adding a function name probably will be ugly. I added a statement that
allows us to understand where those log statements are coming from. Also, we
already print the names of the log segments followed by whether or not the
index and data files exist.
5. Good point. One concern with adding a contstructor without correlation id is
that most users will use it, which will hide the correlation id information.
And this data is useful for troubleshooting. Al though, I wonder how many users
would think that is annoying
6. I found it useful while troubleshooting since that marks the time we
received the request from the socket. In KafkaApis, the statement tells us the
time when it trickles through the queues to actually get handled. This is at
trace anyway and will not show by up in the server log otherwise.
7. Those changes to log4j.properties were not intended to be checked in. I was
trying to see if log4j can be configured to delete older log files
automatically. Turns out it cannot. Will revert those changes. Of course, by
default, the server logs should go to ConsoleAppender
8. State change log in this patch just means everything from kafka.controller.
There is another patch to format the state change log correctly
> Fix correlation ids in all requests sent to kafka
> -------------------------------------------------
>
> Key: KAFKA-683
> URL: https://issues.apache.org/jira/browse/KAFKA-683
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Neha Narkhede
> Priority: Critical
> Labels: improvement, replication
> Attachments: kafka-683-v1.patch, kafka-683-v2.patch
>
>
> We should fix the correlation ids in every request sent to Kafka and fix the
> request log on the broker to specify not only the type of request and who
> sent it, but also the correlation id. This will be very helpful while
> troubleshooting problems in production.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
