arturobernalg commented on PR #559: URL: https://github.com/apache/jspwiki/pull/559#issuecomment-6815554889
Thanks for looking at it. A plugin with plugins nested in it is for example a Table plugin whose cells use CurrentTimePlugin, and a second Table inside one of the cells; this is the page of the ticket. How to check it by hand with the wysiwyg editor: create a page with that content, open it in the wysiwyg editor and save it without changing anything, then look at the page source. Before the fix the text got longer and the cells ended up on one line joined by backslashes. With the fix the text must stay the same. The automatic check is testPluginWithNestedPlugins in HtmlStringToWikiTranslatorTest: it compares a plugin with nested plugins against the same plugin without them, fails without the fix and passes with it. About the regular expression: it only decides where the plugin ends. It now looks for the closing brace and bracket that balance the opening one; if the brackets do not balance, it uses the first closing one as before. I did not repeat the manual check in a browser with the fix. If you want it before merging, tell me and I will do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
