arturobernalg commented on PR #430: URL: https://github.com/apache/jspwiki/pull/430#issuecomment-6657095407
This cannot be merged as it is. I applied it on top of the current master and the HTML to wiki translator stops working: JDOM reports that the feature http://xml.org/sax/features/external-general-entities is not recognized for the SAX driver HtmlStringToWikiTranslator$AttributeUriFilter. The tests fail in three modules (19 of 19, 17 of 53 and 10 of 10), and the war cannot be built, because WikiSyntaxConverter uses the translator while the pages are converted. The same tests pass on master and with the other two bumps I checked. I think jdom2 2.0.6.1 sets that feature on the reader and the filter that wraps htmlunit-neko does not accept it, but I have not tried a fix; that would be a change in HtmlStringToWikiTranslator, apart from this bump. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
