arturobernalg commented on PR #565: URL: https://github.com/apache/jspwiki/pull/565#issuecomment-6665078366
@udittmer, thank you for testing the notifications in JSPWIKI-90. The branch is up to date with master now. One thing I measured: without jspwiki.subscription.baseURL the mail says "You can see it at: /test/Wiki.jsp?page=SubscribedPage", a path without scheme and host, so the link cannot be opened from a mail client. The property is documented in jspwiki.properties, and the engine has no other base URL to use (its getBaseURL() is only the context path). Should the manager write a warning to the log when it sends a mail and the property is empty? If you are happy with the pull request, could you approve it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
