arturobernalg commented on PR #307: URL: https://github.com/apache/jspwiki/pull/307#issuecomment-6344841413
Hi @juanpablo-santos, sorry for the long delay on this one. The change you requested is done and the PR is ready for another pass. The old branch was more than 500 commits behind master, so I rebased it into a single commit on current master, keeping the Synchronizer approach. While porting I fixed three things: WikiEventManager used CopyOnWriteArrayList but removed listeners through Iterator.remove(), which that type does not support (now removeIf), the workflow locks are now transient and recreated in readObject so workflow data saved by earlier releases still loads, and PermissionFactory keeps the collision-free cache key from master. I also removed the jspwiki-util entry from the root pom.xml, as you asked, since jspwiki-main and jspwiki-event already reference it with project.groupId and project.version. The jspwiki-util, jspwiki-event and jspwiki-main modules build and pass all their tests (1111, including a new SynchronizerTest). One caveat: I have not added a test that rep roduces the pinning itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
