weberjn commented on PR #370: URL: https://github.com/apache/jspwiki/pull/370#issuecomment-2413027279
Yes, the needed stripes version is not in central. So I built it locally. See my comment in JSPWIKI-1170. Someone might ask stripes to publish to central. A harder problem still is xmlrpc-2.0.1.jar containing org.xml.sax. I'd suggest to replace the xmlrpc stuff with a REST based implementation. Unfortunately, Jersey is quite large, so this shouldn't be in the wiki by default. Juergen Am Di., 15. Okt. 2024 um 03:05 Uhr schrieb spyhunter99 < ***@***.***>: > ***@***.**** commented on this pull request. > > aside from some formatting related issues in the pom's. changes look > reasonable to me. i also just migrated a huge project to jdk17 with > jakarata. appreciate the work. > > i did run into a compile issue, actually it's dependency resolution. > Here's the output: > > Could not resolve dependencies for project > org.apache.jspwiki:jspwiki-util:jar:3.0.0-SNAPSHOT: > net.sourceforge.stripes:stripes:jar:1.6.0-JakartaEE10 was not found in > https://repo.maven.apache.org/maven2 during a previous attempt > ------------------------------ > > On jspwiki-210-test-adaptees/pom.xml.versionsBackup > <https://github.com/apache/jspwiki/pull/370#discussion_r1800272649>: > > .versionBackup really should be on the ignore list and not in version > control > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/jspwiki/pull/370#pullrequestreview-2367895645>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADILRHCGHQDMXDNLJJQYXR3Z3RS55AVCNFSM6AAAAABPU3PI6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRXHA4TKNRUGU> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
